Why is a "pull request" not a "push request"? 🤔
@GithubProjects It should actually be a merge request
@GithubProjects Because we request them to pull our changes in their repo
@GithubProjects Because it is a request to the upstream to pull content from your repo/branch. You usually cannot push yourself (because you do not have merge rights), so you have to ask them to pull. The active person is the recipient.
@GithubProjects Because you're asking the maintainer to 'pull' the changes from your copy of the repo (with your changes) to the actual repo
@GithubProjects Are u standing at the supermarket door confused again? 😂
@GithubProjects because merge request not a push request))
@GithubProjects I guess you're requesting that you're changed are pulled into the main branch BUT I prefer Merge Request TBH, it removed all questions!
@GithubProjects So that people can pull it to other branches
@GithubProjects Because you're asking the project maintainer to pull your code into their branch/repo
I think the confusion comes because most people have merge permission, so the pull request is only a review step in the workflow, just before they -themselves- merge the changes. So people see “pull requests” as “give me the OK so I can push my changes”, which in this situation seems to be illogical, it's more of a “push request”. On open-source or community projects, there's someone “owning” the project and the code, and you have to request them to merge, hence a “pull -my changes- request”. But most people work on companies with full repository permissions.
@GithubProjects gitlab calls them 'Merge Requests' and it makes more sense
@GithubProjects Push access to the main repo is not available for everyone. A pull request offers an opportunity for someone to suggest modifications even if they don’t have direct entry.
The whole push/pull thing was confusing at first until I started thinking about it from the perspective of each party. The developer pushes a change out to the origin and puts in a pull request. If the powers that be decide to accept this change, they pull it into the origin. At least, that's how I think of it. Which may be incomplete
@GithubProjects The name reflects the main project repository’s perspective, as it ‘pulls’ changes from a contributor’s branch, not the other way around.
@GithubProjects It is a request to someone pulling your new/different code into the main code 👨💻
@GithubProjects This was so confusing to me when I started 😆 to add master’s code to your branch -> pull to add your branch’s code to to master -> pull
@GithubProjects Pull request is from the perspective of the owner of the repo Push request is from the perspective of the contributor to the repo Merge request is netural enough to be understood easily by both parties
@GithubProjects Because you want someone to pull your code into their branch/project. That said, I prefer @gitlab's Merge Request phrasing.
@GithubProjects “Here are some suggested changes. I’m requesting you, the repo maintainer, to pull these changes into your repo and merge them” (e.g. because I have no push access) If anything, it could be named a “merge request”. But a “push request” makes no sense.
@GithubProjects Devs push their changes to a feature branch. The maintainer then *pulls* those changes into the master branch.
@GithubProjects Because if you're pushing something, the person on the other end is pulling it. You're asking someone to pull it from you to merge it.
@GithubProjects Because this feature was built on friday night just after the beer party. 🍻
@GithubProjects Pull implies you are asking permission to have your changes pulled in, which in most cases you are doing unless it's just you that's the dev
@GithubProjects I had to use GitLab for a while and I liked the term 'merge request'. I understand the reasoning behind the term 'pull', but it's not obvious when you're starting out.
@GithubProjects Because you pull your hair out waiting for teammates to review it
@GithubProjects You guys create pull requests ?
@GithubProjects Preferring a "merge request" tbh