PullApprove @pullapprove

Accelerate pull requests, maintain compliance. Built by @davegaeddert. pullapprove.com Kansas Joined October 2015

Tweets

168
Followers

133
Following

181
Likes

34

Dave Gaeddert @davegaeddert

2 years ago

Playing with some small behavioral things on @pullapprove... If a PR hasn't been updated in a while, it will start telling you how many days it has been that way. A little more motivation to deal with it! 🔥

0 1 0 150 0

Download Image

Dave Gaeddert @davegaeddert

2 years ago

Nice to see a @pullapprove mention in here. Always so many rules about what you can and can't say with customers like this! infoq.com/news/2023/08/d…

0 1 0 132 0

Dave Gaeddert @davegaeddert

2 years ago

Worth a quick read. I'd probably summarize as: "readability matters" Tooling can point out basic formatting. But naming, structure, and readability are different. If you don't sweat the details on this stuff, it quickly becomes the code nobody wants to work on. The art of code??

DHH @dhh

2 years ago

13 52 337 62K 83

0 1 1 188 0

ThePrimeagen @ThePrimeagen

2 years ago

during a code review, if you leave a nit and your nit is fine to be ignored don't leave it you clutter the pr you distract from any real issues your preferences are just that, stfu and make a prettier / eslint / clangformat rule and move on with your day

47 43 662 53K 22

Gergely Orosz @GergelyOrosz

2 years ago

Teams with a high quality bar for code reviews are great places to grow professionally. But this same high quality bar can feel intimidating when being a recent joiner. Empathetic engineers pay additional attention for new joiners when doing the first few code reviews:

14 48 495 90K 115

Download Image

Dave Gaeddert @davegaeddert

2 years ago

I've been thinking a lot about AI's role in code review, and have mixed feelings. My biggest concern is that it will *always* find something to point out, especially if it tries to help with "readability". But maybe it can focus on hard-to-find "logical errors" or something?

Matt Carey @mattzcarey

2 years ago

1 2 16 4K 4

Download Image

0 1 2 267 0

Dave Gaeddert @davegaeddert

2 years ago

I think reviewing your own code in a *different UI* makes a huge difference. In VSCode, it looks exactly like it did when I wrote it. It's too easy to gloss over things because it feels like I've already seen it. Reviewing on GitHub puts me in a different headspace...

nunomaduro @enunomaduro

2 years ago

7 11 138 11K 2

0 1 1 111 0

PullApprove @pullapprove

2 years ago

Pair Review: Streamlining Complex Code Reviews with Pair Programming pullapprove.com/posts/pair-rev…

0 0 0 23 0

PullApprove @pullapprove

2 years ago

Break Glass, Not Rules: Ensuring Compliance in Emergency Code Changes pullapprove.com/posts/break-gl…

0 0 0 24 0

Dave Gaeddert @davegaeddert

2 years ago

Integrating an app like @pullapprove with external services means tons of subtle tweaks to smooth out the experience. How do you market the fact that there are literally hundreds of commits and iterations over 6+ years that make it better than most in-house solutions?

1 1 1 92 0

Download Image

Dave Gaeddert @davegaeddert

2 years ago

This is pretty cool. The reviewer doesn't really want to spell out the specifics of a suggestion, and the author doesn't really want to spend time interpreting and implementing if they don't have to. I wonder how often the change fails CI/tests?

Jacob Austin @jacobaustin132

2 years ago

7 71 516 109K 161

Download Image

0 1 1 104 0

Dave Gaeddert @davegaeddert

2 years ago

This has been on my mind for a while but I can’t quite put my finger on how (or if) @pullapprove can help with this. Call scheduling? Transcribe and upload recording? Show who is currently looking at a PR and one-click to call? Nothing?!

Solo Web Dev @SoloWebDev

2 years ago

1 0 6 5K 0

0 1 1 119 0

Dave Gaeddert @davegaeddert

2 years ago

The note about healthy team dynamics is an important one — are the personal interactions good? Reviewing code can be a touchy subject. Same for tooling — is the tool causing frustration or streamlining a mandatory process? The related thing I've had in mind here is some super…

Dave Gaeddert @davegaeddert

2 years ago

0 2 24 12K 15

0 1 0 241 0

Dave Gaeddert @davegaeddert

2 years ago

Been thinking a lot about more ways code review can help a team/organization. This idea of "meta code review" is certainly one of them! @pullapprove could help facilitate this for managers. Staying technical as an engineering manager, by @GergelyOrosz open.substack.com/pub/pragmatice…

0 2 24 12K 15

Dave Gaeddert @davegaeddert

2 years ago

I regularly do this too. I intentionally review it on GitHub and catch stuff that I didn't see in my IDE/terminal. Authors can't approve their own PR on GitHub, but it does have me wondering how @pullapprove could encourage/enforce it? Benefits to making it a required step?

John Nunemaker @jnunemaker

2 years ago

53 10 284 25K 2

0 1 1 123 0

Download Image

Dave Gaeddert @davegaeddert

3 years ago

Finally working on a new iteration of PullApprove. The new UI is starting to feel kinda nice!

0 1 1 125 0

Download Image

Dave Gaeddert @davegaeddert

3 years ago

Been wondering for a while about how to add some interactivity to my code examples. Main idea is that you can write markdown like usual, and get some "turbocharging" when it hits your site. Tabs for separate files or languages, copy/paste buttons, a way to show a filename, etc

1 1 0 0 0

Download Gif

Dave Gaeddert @davegaeddert

4 years ago

Nice graphic if you're thinking about aspects of code review. My favorite thing to see people do with pullapprove.com is dial in their PR flow to where reviewers aren't even *notified* until it is ready for them. Don't have to comment on code style, failing tests, etc.